-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayoutBuilder template using either ForthMachine32 or ForthMachine64 and a tutorial #1063
Conversation
Absolutely, I'll take a look tomorrow!
…On Tue, 24 Aug 2021, 17:01 Ianna Osborne, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs-src/how-to-create-layoutbuilder.md
<#1063 (comment)>
:
> +builder.tag(1)
+builder.boolean(True)
+builder.tag(0)
+builder.float64(4.4)
+builder.tag(1)
+builder.boolean(False)
+builder.tag(1)
+builder.boolean(True)
+builder.tag(0)
+builder.float64(-2.2)
+```
+
+Snapshot
+--------
+
+To turn a #ak::LauoutBuilder into a layout, call `snapshot`. This is an inexpensive operation (may be done multiple times; the builder is unaffacted).
@agoose77 <https://github.com/agoose77> - Can I take you up on your kind
offer of code review? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1063 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJQZHIWEM6EMCB4O5KJWIDT6O66VANCNFSM5CLWECQA>
.
|
@jpivarski - I think, I'm done with this PR. It introduces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation looks good to me, and I'm glad that writing it inspired some tweaks to the code. The references to class names could be links, as I've said in a comment above, and that would be an improvement.
Thanks @agoose77 for the review! You brought up some good points.
No description provided.