Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutBuilder template using either ForthMachine32 or ForthMachine64 and a tutorial #1063

Merged
merged 9 commits into from
Aug 26, 2021

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Aug 18, 2021

No description provided.

@ianna ianna marked this pull request as draft August 18, 2021 11:26
@ianna ianna requested a review from agoose77 August 24, 2021 15:58
@ianna ianna marked this pull request as ready for review August 24, 2021 18:58
@agoose77
Copy link
Collaborator

agoose77 commented Aug 24, 2021 via email

@ianna ianna changed the title LayoutBuilder tutorial LayoutBuilder template using either ForthMachine32 or ForthMachine64 and a tutorial Aug 24, 2021
@ianna ianna requested a review from jpivarski August 24, 2021 20:44
@ianna
Copy link
Collaborator Author

ianna commented Aug 24, 2021

@jpivarski - I think, I'm done with this PR. It introduces LayoutBuilder32 and LayoutBuilder64, plus the error handling is improved, I think.

docs-src/how-to-create-layoutbuilder.md Outdated Show resolved Hide resolved
docs-src/how-to-create-layoutbuilder.md Show resolved Hide resolved
docs-src/how-to-create-layoutbuilder.md Show resolved Hide resolved
src/python/content.cpp Show resolved Hide resolved
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks good to me, and I'm glad that writing it inspired some tweaks to the code. The references to class names could be links, as I've said in a comment above, and that would be an improvement.

Thanks @agoose77 for the review! You brought up some good points.

@jpivarski
Copy link
Member

Oh, and I'm holding off on merging until you decide what you want to do about @agoose77's comments, @ianna. Although when you've addressed everything, you can do the merge. That's what my sign-off above means.

@ianna ianna merged commit b1e342d into main Aug 26, 2021
@ianna ianna deleted the ianna/layout-builder-tutorial branch August 26, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants