Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore to list of ignored files #438

Closed
wants to merge 1 commit into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 18, 2023

I didn't add a test, but would be happy to do so. The reason I waited is that it seems like the easiest option would be to add the file to one of the existing tests/packages examples, but that would require modifying the hashes and I wasn't sure if that would be the preferred result.

Partially addresses #437, but only for the special case of gitignore. This doesn't fix the more general case of hidden files.

@vyasr vyasr marked this pull request as draft July 18, 2023 18:25
@henryiii
Copy link
Collaborator

I think it's important to keep the .gitignore(s) in the SDist - it should only excluded from wheels. Maybe we should have some better defaults, and some control over the defaults. I've got an idea, and will try to get back on this in a bit (in the middle of four conferences in three weeks!).

The key problem in #437 would be fixed by fixing the logic for files that start with a dot, which are not valid packages so should be skipped.

@vyasr
Copy link
Contributor Author

vyasr commented Aug 7, 2023

I'll close this for now since I agree that it doesn't seem like the right fix. Happy to reopen if anything changes or to help work on an alternative fix later.

@vyasr vyasr closed this Aug 7, 2023
@henryiii
Copy link
Collaborator

henryiii commented Aug 7, 2023

Does the current version (0.4.8) work, by the way? It should be "fixed" (probably still coping the .gitignore's to the package, which still needs fixing, but the editable installs should no longer be broken).

@vyasr
Copy link
Contributor Author

vyasr commented Aug 7, 2023

I hadn't seen the latest release, thanks for the update. Yes, I just tested and the build no longer fails. I'm not sure what behavior you are hoping to see for gitignores to call the issue truly resolved, but it sounds like you want to fix the set of files that get included and have them be different for wheels and sdists. Happy to discuss if you need any further help/input there.

@vyasr vyasr deleted the fix/gitignore branch August 8, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants