Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix msys failures #256

Merged
merged 9 commits into from
Apr 4, 2023
Merged

tests: fix msys failures #256

merged 9 commits into from
Apr 4, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 4, 2023

Testing to see if I can fix the address space needed by '_common.cpython-311-x86_64-msys.dll' (0x620000) is already occupied failures. Switching to UCRT instead, currently disabling a few setuptools tests to get it to pass. Speeding up the tests, too.

Signed-off-by: Henry Schreiner <[email protected]>
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #256 (7a197e0) into main (e2a1479) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   88.10%   88.15%   +0.05%     
==========================================
  Files          51       51              
  Lines        2236     2238       +2     
==========================================
+ Hits         1970     1973       +3     
+ Misses        266      265       -1     
Impacted Files Coverage Δ
src/scikit_build_core/builder/sysconfig.py 80.26% <50.00%> (+1.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Collaborator Author

henryiii commented Apr 4, 2023

This still fails (maybe fewer failures?), so I think we'll have to disable this job until msys2/MSYS2-packages#3708 has some resolution or suggestions.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@henryiii henryiii marked this pull request as ready for review April 4, 2023 21:32
@henryiii henryiii merged commit d0b6d0f into main Apr 4, 2023
@henryiii henryiii deleted the henryiii/ci/msys branch April 4, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant