Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded copying. #12

Merged
merged 3 commits into from
Feb 7, 2020

Commits on Nov 15, 2019

  1. Remove unneeded copying.

    When algorithm operates by modifying the input array in place, it is
    good manners to make a copy first so that the function does not mutate
    user input. I am guessing that that was the motivation for the use of
    `copy()` here.
    
    However, as far as I can tell, this algorithm does not modify `signal`
    (or its alias `a`) in place. It reassigns the variable `a` in a loop,
    but does not actually modify the input array object.
    
    Therefore, we can remove this copying and increase the speed. Also, note
    that the call to `np.array` explicitly cast the input to a literal numpy
    array. By removing that from the code, we accept dask arrays and cupy
    arrays and allow them to flow through the algorithm via the NEP-18 numpy
    dispatch mechanism.
    danielballan committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    8c4a1be View commit details
    Browse the repository at this point in the history
  2. Use ndim.

    danielballan committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    3d757d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Configuration menu
    Copy the full SHA
    8b00512 View commit details
    Browse the repository at this point in the history