[WIP] Add CuPy backend #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice! I just noticed this PR. This seems interesting to me! I did the same for a dask-based version that I need to open a PR for. Would be great if you could keep pressing on this when you have time. |
Merged
|
Looks like we won't need this PR once #15 is resolved. Closing this for now... |
Note to myself: I am not saying the current NumPy-based implementation is also performant with CuPy. I am not sure what's the typical data size to be processed, so if this is a concern, we'll still need a specialized GPU version. |
|
Superseded by #17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experimental work demonstrating how easy a NumPy code can be ported to CuPy that runs on NVIDIA GPUs. This is still a WIP as
fftautocorris awfully slow;multitauseems OK. If there is interest I can work on polishing and optimizing the code, adding CuPy tosetup.pyas an optional dependency, etc.