Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full text search capability for text, including OCR text—when searching within Hyku, search results should include the text of embedded pdfs #772

Closed
1 of 4 tasks
Tracked by #903
jillpe opened this issue Sep 8, 2023 · 1 comment
Closed
1 of 4 tasks
Tracked by #903

Full text search capability for text, including OCR text—when searching within Hyku, search results should include the text of embedded pdfs #772

jillpe opened this issue Sep 8, 2023 · 1 comment
Assignees
@ShanaLMoore @kirkkwang
Labels
Sprint: Odds and Ends

Comments

@jillpe
Copy link

jillpe commented Sep 8, 2023 •
edited
Loading

Summary

Pals would like OCR text, and full text search capability for searching text from a PDF through the catalog

Accepted Criteria

  • A PDF can be found by inputting it's text in the search catalogue
  • When found in the search results, a text snippet displays with it's search result

Testing Instruction

  • Create a work with a PDF and make sure the viewer is visible

In-Viewer Search

  • Click the search icon at the top of the viewer
  • Search a term
    • the term is identified and highlighted on the PDF wherever it occurs

Catalogue Search

  • in the catalogue search, search for a term that is in the PDF
    • the PDF shows as a search result and the term is highlighted in the text snippet that appears with it
@jillpe jillpe mentioned this issue Sep 8, 2023
Closed
51 tasks
@jillpe jillpe moved this to Ready for Development in palni-palci Sep 11, 2023
@ShanaLMoore ShanaLMoore mentioned this issue Sep 11, 2023
Merged
@kirkkwang kirkkwang mentioned this issue Sep 12, 2023
Merged
@jillpe
Copy link
Author

jillpe commented Sep 13, 2023 •
edited
Loading

SoftServ QA:

PDF tested

In-viewer search ✅

Image

Catalogue Search ✅

Image

@jillpe jillpe moved this from Ready for Development to ReShare QA in palni-palci Sep 13, 2023
@jillpe jillpe moved this from ReShare QA to PALs QA in palni-palci Sep 13, 2023
@ndroark ndroark moved this from PALs QA to Deploy to Production in palni-palci Sep 14, 2023
kirkkwang added a commit that referenced this issue Sep 15, 2023
@kirkkwang
🐛 Fix double render error
4750b73 
Sometimes when you search for a phrase the results will throw an
exception.  This commit will fix that by calling the IIIF Print version
of the `#render_ocr_snippets` method.

Ref:
  - #772
@kirkkwang kirkkwang mentioned this issue Sep 15, 2023
Merged
@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Client Verification in palni-palci Sep 21, 2023
@ndroark ndroark moved this from Client Verification to Done in palni-palci Oct 2, 2023
@jillpe jillpe closed this as completed Oct 3, 2023
@jillpe jillpe mentioned this issue Nov 8, 2023
Closed
32 tasks
jeremyf pushed a commit to samvera/hyku that referenced this issue Dec 15, 2023
@kirkkwang @jeremyf
🐛 Fix double render error
aa47242 
Sometimes when you search for a phrase the results will throw an
exception.  This commit will fix that by calling the IIIF Print version
of the `#render_ocr_snippets` method.

Ref:
  - scientist-softserv/palni-palci#772
@jeremyf jeremyf mentioned this issue Dec 15, 2023
Closed
jeremyf pushed a commit to samvera/hyku that referenced this issue Dec 19, 2023
@ShanaLMoore @kirkkwang @jeremyf
🎁 Contributions from PALNI/PALCI
6a1e0c5 
Which were resolved via the following PRs:

- scientist-softserv/palni-palci#768
- scientist-softserv/palni-palci#786
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#807
- scientist-softserv/palni-palci#850
- scientist-softserv/palni-palci#781
- scientist-softserv/palni-palci#787
- scientist-softserv/palni-palci#795
- scientist-softserv/palni-palci#788
- scientist-softserv/palni-palci#793
- scientist-softserv/palni-palci#782
- scientist-softserv/palni-palci#798
- scientist-softserv/palni-palci#866
- scientist-softserv/palni-palci#846
- scientist-softserv/palni-palci#849
- scientist-softserv/palni-palci#868
- scientist-softserv/palni-palci#875
- scientist-softserv/palni-palci#884
- scientist-softserv/palni-palci#876
- scientist-softserv/palni-palci#952

Contribute back the following features:

- scientist-softserv/palni-palci#125
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#742
- scientist-softserv/palni-palci#746
- scientist-softserv/palni-palci#772
- scientist-softserv/palni-palci#773
- scientist-softserv/palni-palci#774
- scientist-softserv/palni-palci#776
- scientist-softserv/palni-palci#778
- scientist-softserv/palni-palci#839
- scientist-softserv/palni-palci#840
- scientist-softserv/palni-palci#864

Co-authored-by: Shana Moore <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
@jeremyf jeremyf mentioned this issue Dec 22, 2023
Closed
This was referenced Jan 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

@kirkkwang kirkkwang

Labels
Sprint: Odds and Ends
Projects
palni-palci
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @kirkkwang @jillpe