Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CatalogSearch feature parity #258

Closed
Tracked by #113
ShanaLMoore opened this issue Oct 5, 2023 · 2 comments
Closed
Tracked by #113

CatalogSearch feature parity #258

ShanaLMoore opened this issue Oct 5, 2023 · 2 comments
Labels
Knapsack Upgrade

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Oct 5, 2023 •
edited
Loading

Summary

In adventist proper's staging, work details are displayed in the catalog search results page.

For example, for Journal article we see the following displayed:

  • Author
  • Part of
  • Date
  • Subject
  • Source
  • Description

This ticket is to check each work type and/or make adventist knapsack display the same. Notice we also have a lot of translations missing.

Staging example

Image

ADV Knapsack example

Image
@ShanaLMoore ShanaLMoore changed the title CatalogSearch CatalogSearch feature parity Oct 5, 2023
jeremyf referenced this issue Oct 5, 2023
@jeremyf
🐛 Ensure knapsack translations are first choice
841e3f9 
Prior to this change, assuming my default translation was "en" when I
called the following—`I18n.t('dog_biscuits.fields.date_issued')`—I would
get `Translation missing: en.dog_biscuits.fields.date_issued`.

We had added DogBiscuits into that path but we had not reloaded the
back-end.

Further, the catalog controller was no longer doing useful work.  The
`Rails.root` is `hyrax-webapp`; which would already be working.  For
more on this anti-pattern, see [Potential Issues Around Knapsack and Rails.root][1].

With this change, I have a small test to verify that dog biscuits
translations are in fact loaded.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244

[1]: #60)
@jeremyf jeremyf mentioned this issue Oct 5, 2023
Merged
jeremyf referenced this issue Oct 5, 2023
@jeremyf
🐛 Ensure knapsack translations are first choice
654bdb6 
Prior to this change, assuming my default translation was "en" when I
called the following—`I18n.t('dog_biscuits.fields.date_issued')`—I would
get `Translation missing: en.dog_biscuits.fields.date_issued`.

We had added DogBiscuits into that path but we had not reloaded the
back-end.

Further, the catalog controller was no longer doing useful work.  The
`Rails.root` is `hyrax-webapp`; which would already be working.  For
more on this anti-pattern, see [Potential Issues Around Knapsack and Rails.root][1].

With this change, I have a small test to verify that dog biscuits
translations are in fact loaded.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244

[1]: #60)
jeremyf referenced this issue Oct 5, 2023
@jeremyf
🐛 Ensure knapsack translations are first choice
50dd0c7 
Prior to this change, assuming my default translation was "en" when I
called the following—`I18n.t('dog_biscuits.fields.date_issued')`—I would
get `Translation missing: en.dog_biscuits.fields.date_issued`.

We had added DogBiscuits into that path but we had not reloaded the
back-end.

Further, the catalog controller was no longer doing useful work.  The
`Rails.root` is `hyrax-webapp`; which would already be working.  For
more on this anti-pattern, see [Potential Issues Around Knapsack and Rails.root][1].

With this change, I have a small test to verify that dog biscuits
translations are in fact loaded.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244

[1]: #60)
jeremyf referenced this issue Oct 5, 2023
@jeremyf
🐛 Ensure knapsack translations are first choice (#63)
740fd2a 
Prior to this change, assuming my default translation was "en" when I
called the following—`I18n.t('dog_biscuits.fields.date_issued')`—I would
get `Translation missing: en.dog_biscuits.fields.date_issued`.

We had added DogBiscuits into that path but we had not reloaded the
back-end.

Further, the catalog controller was no longer doing useful work.  The
`Rails.root` is `hyrax-webapp`; which would already be working.  For
more on this anti-pattern, see [Potential Issues Around Knapsack and
Rails.root][1].

With this change, I have a small test to verify that dog biscuits
translations are in fact loaded.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244

[1]: #60)
jeremyf referenced this issue Oct 6, 2023
@jeremyf
🐛 Ensure Catalog i18ns favor knapsack
3eeea64 
Prior to this change, we had ensured knapsack's translations took
precedence over Hyku's.  However, that ensuring occurred at the
after_initialize.  We had missed the CatalogController's translation
moment as well.

When we specify the index fields in the CatalogController, blacklight
caches those translations.  However, in the case of dogbiscuits, those
are not yet loaded.  Which results in a translation error; even though
we later load the dog biscuits translations.

With this change, I have added two tests to:

1. verify that translations are correct for the catalog controller
2. that when the app boots, the Knapsack translations take precedence
   over Hyku.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244
- #63

[1]: #60)
@jeremyf jeremyf mentioned this issue Oct 6, 2023
Merged
jeremyf referenced this issue Oct 6, 2023
@jeremyf
🐛 Ensure Catalog i18ns favor knapsack (#65)
db63a45 
Prior to this change, we had ensured knapsack's translations took
precedence over Hyku's.  However, that ensuring occurred at the
after_initialize.  We had missed the CatalogController's translation
moment as well.

When we specify the index fields in the CatalogController, blacklight
caches those translations.  However, in the case of dogbiscuits, those
are not yet loaded.  Which results in a translation error; even though
we later load the dog biscuits translations.

With this change, I have added two tests to:

1. verify that translations are correct for the catalog controller
2. that when the app boots, the Knapsack translations take precedence
   over Hyku.

Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244
- #63

[1]: #60)
@jeremyf
Copy link
Contributor

jeremyf commented Oct 6, 2023

The fonts are different but the translations are up (I think someone's working on the UI tests for fonts)

@KatharineV
Copy link
Collaborator

KatharineV commented Oct 11, 2023 •
edited
Loading

Testing results

Journal Article

  • On prod: Author, Part of, Date, Subject, Source, Description.
  • On Knapsack: Author, Part of, Subject, Source, Description.
  • Date field needs to be added.

Image

  • On prod: Author, Part of, Date, Subject, Source, Description
  • On Knapsack: Author, Part of, Subject, Source, Description
  • Date field needs to be added.

Published Work

  • On prod: Author, Date, Subject, Source, Description.
  • On Knapsack: Author, Date, Subject, Source.
  • Need to add Description.

Generic Work
NOTE: This is called "Work" on ADL prod and "Generic Work" on Knapsack.

  • On prod: Author, Part of, Date, Subject, Source, Description.
  • On Knapsack: Author, Part of, Date, Subject, Source, Description.
  • Nothing to add.

Collection

  • On prod: Author, Date, Subject, Description.
  • On Knapsack: Author, Date, Subject, Description.
  • Nothing to add.

Thesis

  • On prod: Author, Date, Subject, Source, Description.
  • On Knapsack: Author, Date, Subject, Source.
  • Need to add Description.

Conference Item:

  • On prod: Author, Part of, Subject.
  • On Knapsack: Author, Part of, Subject.
  • Nothing to add.

Dataset

  • On prod: Author, Date, Subject, Source.
  • On Knapsack: Author, Date, Subject, Source.
  • Nothing to add.

Exam Paper:

  • On prod: Author, Subject, Source, Description.
  • On Knapsack: Author, Date, Subject, Source.
  • Nothing to add.

jeremyf referenced this issue Oct 12, 2023
@jeremyf @laritakr
♻️ Return date_issued i18n to "Date Issued"
de1db3d 
Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244
- #63
- #60

Co-authored-by: LaRita Robinson <[email protected]>
jeremyf referenced this issue Oct 12, 2023
@jeremyf @laritakr
♻️ Return date_issued i18n to "Date Issued"
71a51a2 
Related to:

- https://github.com/scientist-softserv/adventist-dl/issues/611
- https://github.com/scientist-softserv/adventist-dl/issues/227
- scientist-softserv/adventist-dl#244
- #63
- #60

Co-authored-by: LaRita Robinson <[email protected]>
@jeremyf jeremyf mentioned this issue Dec 7, 2023
Open
29 tasks
@kirkkwang kirkkwang transferred this issue from scientist-softserv/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Knapsack Upgrade
Projects
adventist-dl
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremyf @ShanaLMoore @KatharineV