Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also remove installation dir with build --clean #28

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Also remove installation dir with build --clean #28

merged 1 commit into from
Dec 1, 2022

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Nov 30, 2022

@rgommers Is your expectation that ./dev.py build --clean should also erase the build-install directory?

My gut feel is yes, but I'm not 100% sure.

@rgommers
Copy link
Contributor

That makes sense to me, yes. I'll also note that I don't have any use for --clean, I use git clean -xdf which will be more reliable. The SciPy dev.py doesn't even have --clean, and we disabled the setuptools clean command ages ago because it was unreliable.

@stefanv stefanv merged commit 77ca322 into scientific-python:main Dec 1, 2022
stefanv added a commit that referenced this pull request Dec 1, 2022
@stefanv
Also remove installation dir with build --clean (#28)
e65f153
@jarrodmillman jarrodmillman added this to the 0.1 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanv @rgommers @jarrodmillman