Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pytest based testing framework and tests for build #160

Merged
merged 17 commits into from
Feb 13, 2024

Conversation

ganesh-k13
Copy link
Contributor

@ganesh-k13 ganesh-k13 commented Jan 27, 2024

Changes

  • Add a pytest based testing framework
  • Add tests for
    • --version
    • build

Notes

  • part of Improve unit testing using frameworks #154
  • I'll club the relevant commands and raise PRs to not bloat one single big bang PR.
  • Additionally, the faster this goes in, we need not maintain tests in two places, i.e. spin/tests and .github/workflows/test.sh

@ganesh-k13 ganesh-k13 marked this pull request as draft January 27, 2024 14:36
@stefanv
Copy link
Member

stefanv commented Jan 27, 2024

Thanks, this is a great start! After merging #159 tomorrow, I'll get this in, and then spend some time porting the tests (unless someone beats me to it!).

@ganesh-k13
Copy link
Contributor Author

Thanks @stefanv! No worries :) I'll try to port all the tests, just wanted to ensure I'm on the right track.

@stefanv stefanv added the type: Enhancement New feature or request label Jan 30, 2024
@stefanv
Copy link
Member

stefanv commented Feb 10, 2024

@ganesh-k13 @jarrodmillman Can you take a look? I think this is ready now.

@stefanv stefanv marked this pull request as ready for review February 10, 2024 01:43
@stefanv stefanv merged commit a8c5219 into scientific-python:main Feb 13, 2024
17 checks passed
@jarrodmillman jarrodmillman added this to the 0.9 milestone Feb 13, 2024
@ganesh-k13
Copy link
Contributor Author

Thanks @stefanv ! I was away for a few weeks.

@stefanv
Copy link
Member

stefanv commented Feb 15, 2024

Thanks for getting this started, @ganesh-k13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants