Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed file warning on debug python #127

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ngoldbaum
Copy link
Contributor

Debug builds of python have a warning about this that displays every time I run numpy's spin config:

nathan at rous in ~/Documents/numpy on rename-numpy-core!
± python -m spin test
Invoking `build` prior to running tests:
/home/nathan/.pyenv/versions/3.10.9-debug/lib/python3.10/site-packages/spin/cmds/meson.py:99: ResourceWarning: unclosed file <_io.TextIOWrapper name='build/meson-info/meson-info.json' mode='r' encoding='UTF-8'>
  meson_info = json.load(open(meson_info_fn))
ResourceWarning: Enable tracemalloc to get the object allocation traceback

@jarrodmillman jarrodmillman added the type: Bug fix Something isn't working label Oct 13, 2023
@stefanv stefanv merged commit 0e800b9 into scientific-python:main Nov 2, 2023
17 of 18 checks passed
@stefanv
Copy link
Member

stefanv commented Nov 2, 2023

Thanks!

@jarrodmillman jarrodmillman added this to the 0.8 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants