Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added coverage option for test command #100

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

ganesh-k13
Copy link
Contributor

Changes

  • ENH: Added coverage option for test command

Testing

spin test --coverage -- -vv

Output:

...
Coverage HTML written to dir /home/ganesh/os/devpy/example_pkg/build/coverage/
...
~/os/devpy/example_pkg (coverage) » ls build/coverage                                                                                                                 130 ↵ ganesh@ganesh-MS-7B86
coverage_html.js  d_8d15ffec5afca27f___init___py.html  d_b2ad4cdda83343df_test_core_py.html  favicon_32.png  index.html  keybd_closed.png  keybd_open.png  status.json  style.css

@stefanv
Copy link
Member

stefanv commented Aug 13, 2023

Thanks, Ganesh. I recently did a bunch of work on NumPy's commands, so will probably port that command over. I don't recall of it has a coverage option, but if not will integrate your changes from here. Thanks again!

spin/cmds/meson.py Outdated Show resolved Hide resolved
spin/cmds/meson.py Outdated Show resolved Hide resolved
spin/cmds/meson.py Outdated Show resolved Hide resolved
@stefanv stefanv merged commit c06bf60 into scientific-python:main Aug 19, 2023
@stefanv
Copy link
Member

stefanv commented Aug 19, 2023

Thanks, Ganesh, much appreciated.

@jarrodmillman jarrodmillman added this to the 0.6 milestone Aug 19, 2023
@ganesh-k13
Copy link
Contributor Author

Thanks Stefan, I'll start work with NumPy now. I'll target the docs and CI (if any needed)

@stefanv
Copy link
Member

stefanv commented Aug 19, 2023

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants