Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix multiline code in generate/update diff #253

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Jun 27, 2024

The code may have more than one line, so need to account for that.

Closes gh-252

The code may have more than one line, so need to account for that.

Closes scientific-pythongh-252
@bsipocz bsipocz added the bug label Jun 27, 2024
@bsipocz bsipocz added this to the 1.3.0 milestone Jun 27, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this fix!

I'll push a commit for the changelog and then merge.

@bsipocz bsipocz merged commit 99350f8 into scientific-python:main Jun 27, 2024
@seberg seberg deleted the fix-multiline-generate-diff branch June 27, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: generate-diff removes part of command not just the output
2 participants