Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use numpy printoptions in testing #211

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 1, 2023

This gets rid of the testing failure. Whether to have a directive to accept multiple repr ways or not is a separate question and if the answer is yes, that should come in a separate enhancement PR.

@bsipocz bsipocz added this to the 1.0.0 milestone Aug 1, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we define a NUMPY_LT_2 or something so it is easy to grep in the future when we bump minversion?

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2023

Should we define a NUMPY_LT_2 or something so it is easy to grep in the future when we bump minversion?

I think this is an overkill until we need to use the version conditional at multiple places.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2023

(also, note numpy is not really a dependency, we just use it for the tests, so its minversion is a bit of a grey zone.)

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, so merging. Thanks!

@pllim pllim merged commit a893bb4 into scientific-python:main Aug 1, 2023
@bsipocz bsipocz deleted the ci_np_2.0 branch December 13, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants