Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Support testcleanup #165

Merged
merged 1 commit into from
Sep 17, 2021
Merged

ENH: Support testcleanup #165

merged 1 commit into from
Sep 17, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 15, 2021

Fix #164

@pllim pllim requested a review from saimn September 15, 2021 21:24
@saimn
Copy link
Contributor

saimn commented Sep 16, 2021

Looks good to me but maybe another pair of eyes would be useful.

@pllim pllim requested a review from bsipocz September 16, 2021 13:25
@pllim pllim mentioned this pull request Sep 16, 2021
Merged
9 tasks
@Cadair
Copy link
Contributor

Cadair commented Sep 17, 2021

Looks reasonable, but I don't really know how this works.

@pllim
Copy link
Contributor Author

pllim commented Sep 17, 2021

YOLO?

@nstarman
Copy link

This looks very useful! I've been using

.. doctest::
   :hide:

   >>> code
```

But this PR is cleaner. And better explains why the code is hidden.

@saimn
Copy link
Contributor

saimn commented Sep 17, 2021

Ok, let's merge then! Thanks @pllim.

@saimn saimn merged commit 96165e3 into scientific-python:main Sep 17, 2021
@pllim pllim deleted the testcleanup branch September 17, 2021 21:20
@pllim
Copy link
Contributor Author

pllim commented Sep 19, 2021

@saimn , should the next release be v0.10.2 or v0.11.0 ?

@pllim pllim added this to the 0.11.0 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saimn saimn saimn approved these changes

@bsipocz bsipocz Awaiting requested review from bsipocz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Why is there testsetup but no testcleanup?
4 participants
@pllim @saimn @Cadair @nstarman