-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup updates, remove Python 3.6 #159
Conversation
Please add a changelog entry as we used to note dropping of supported versions. Otherwise this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the build wheel label for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I get it now. LGTM and I agree with @bsipocz 's comment about change log.
Ok, done. |
Because `astropy` is about to start using features introduced in `pytest-doctestplus` 0.11.0, the minimum required version needs to be updated. Furthermore, the minimum supported Python version for `pytest-doctestplus` is 3.7 since scientific-python/pytest-doctestplus#159, which means support for Python 3.6 must be dropped here too.
Small updates while using doctestplus as an example for sphinx-astropy.