lint: unify formatting Black with Ruff #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! I will review these next week. I try to keep several different repos linting/ci stuff in sync so I can automate these kinds of linting / CI changes at the same time. So I will update the other repos at the same time. |
|
@jarrodmillman, did you have a chance to have a look at this PR? 🦩 |
|
it seems it was merged in @jarrodmillman's PR #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Ruff is already used in this project and it is fully compatible with Black formatting, I would suggest using Ruff for all to reduce eventual collision between linting and formatting