Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple summaries per pull request #53

Merged
merged 17 commits into from
Jan 29, 2024

Commits on Nov 13, 2023

  1. Uncouple PRs and summaries with new ChangeNote class

    The new dataclass ChangeNote helps with uncoupling the `_query.py` logic
    and the `_format.py` logic from each other somewhat. In this case
    one pull request can be turned into multiple change notes which might
    appear in separate sections. This optional behavior allows to deal with
    somewhat large or unfocused pull requests.
    
    Long-term this step would also be necessary in case PyGitHub is replaced
    with a GraphQl-based approach.
    lagru committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f39fc8e View commit details
    Browse the repository at this point in the history
  2. Uncouple PRs and summaries with new Contributor class

    The new dataclass Contributor helps with uncoupling the `_query.py` logic
    and the `_format.py` logic from each other somewhat.
    
    Long-term this step would also be necessary in case PyGitHub is replaced
    with a GraphQl-based approach.
    lagru committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    043d0ca View commit details
    Browse the repository at this point in the history
  3. Print notes to stdout after potential warnings

    Querying and formatting might generate warnings. Make sure that these
    are printed before the generated notes.
    lagru committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    72e88ce View commit details
    Browse the repository at this point in the history
  4. Add basic integration tests for the formatter classes

    This is nothing to fancy but it should catch unexpected changes in
    our formatting logic and cover the happy path.
    lagru committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    831a0e1 View commit details
    Browse the repository at this point in the history
  5. Add CI workflow for test suite

    lagru committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    219c92d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    62cbdac View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Remove whitespace

    Co-authored-by: Stefan van der Walt <[email protected]>
    lagru and stefanv authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b56b063 View commit details
    Browse the repository at this point in the history
  2. Remove whitespace

    Co-authored-by: Stefan van der Walt <[email protected]>
    lagru and stefanv authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6c7c41b View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Use fenced-code block based syntax for summary labels

    This syntax should hopefully be more robust than the previous one based
    on the relatively common ":" character.
    lagru committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f5aac7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8258f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c58076 View commit details
    Browse the repository at this point in the history
  4. Use Py3.9 compatible typing

    lagru committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3db5725 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e99aa5f View commit details
    Browse the repository at this point in the history
  6. Test for fallback to title

    lagru committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d22a760 View commit details
    Browse the repository at this point in the history
  7. Cleanup code

    lagru committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d846fb1 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Document multiple summary feature in README

    Attempts to make the usage of the new feature clearer.
    lagru committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    daa21af View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Apply suggestion

    Co-authored-by: Stefan van der Walt <[email protected]>
    lagru and stefanv authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    13a7303 View commit details
    Browse the repository at this point in the history