Add project specific configuration via local or remote pyproject.toml
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to have three sources of configuration, in order of priority: - Local TOML file specified with --config option - Remote pyproject.toml at the last given revision - Default configuration in _config.py
stefanv
reviewed
Sep 23, 2023
Of course, I just didn't get to that part yet. ^^ |
|
Looks good to me! As soon as there's a pointer from the README to the example config, we're good to go. |
and tweak or extend other sections accordingly.
lagru
commented
Oct 2, 2023
| [tool.changelist.label_section_map] | ||
| ".*Highlight.*" = "Highlights" | ||
| ".*New feature.*" = "New Features" | ||
| ".*API.*" = "API Changes" |
There was a problem hiding this comment.
Re #41, the API changes section is third now.
and also hint that changelist is not intended to replace the human part in documenting a release.
jarrodmillman
approved these changes
Oct 2, 2023
bsipocz
reviewed
Oct 2, 2023
| If a configuration option is not specified in either file above, changelist | ||
| falls back to the following configuration: | ||
|
|
||
| ````toml |
There was a problem hiding this comment.
Could this be somehow sourced into the README from the actual reference? To lower the chance of diverging the docs from the actual behaviour.
There was a problem hiding this comment.
I will merge and follow-up with a PR to (hopefully) address your suggestions.
2 tasks
lagru
added a commit
to lagru/changelist
that referenced
this pull request
Oct 3, 2023
Didn't push them to scientific-python#30 in time.
jarrodmillman
pushed a commit
that referenced
this pull request
Oct 3, 2023
Didn't push them to #30 in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17. Closes #23.
The idea is to have three sources of configuration, in order of priority:
--configoptionpyproject.tomlat the last given revision_config.pyFor the release notes: