Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics/add blacklist #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sashless
Copy link

  • replaced whitelist by blacklist
  • can provide string and regex as blacklist entry

@sashless
Copy link
Author

@sballesteros is this something you would merge , should i resolve conflicts ?

@BigBlueHat
Copy link

@sashless nice addition. I'm noticing things like <dt> aren't in whitlist, so this flip is probably prudent.

@sballesteros thoughts?

@BigBlueHat
Copy link

Oh. My bad. That's old code. The current citeable list includes <dt> and several others.

I do wonder which is easier to keep track of...or, given that window.getSelection() already avoids it how necessarily it is (except wrt WebVerse.addIdentifiers()). Hrm....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants