Feat: Create SciELO Citation Index converter #770
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return articles | ||
|
|
||
| def create_article_tag(self): |
There was a problem hiding this comment.
@Rossi-Luciano vamos considerar que 1 artigo por XML, o usuário da classe ou do módulo, montará o Xml inteiro.
| from packtools.sps.models.article_and_subarticles import ArticleAndSubArticles | ||
|
|
||
|
|
||
| class SciELOCitationConverter: |
There was a problem hiding this comment.
@Rossi-Luciano não precisa usar classes como no articlemeta. Pode ser funções como tem sido feito. Também não precisa se limitar a uma classe, lembrando que 1 classe representa objetos. Então, pode-se ter uma classe para autores, para afiliações, etc.
robertatakenaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Adiciona classe para converter um arquivo XML no formato padrão SciELO para o formato SciELO Citation Index.
Onde a revisão poderia começar?
Por commit.
Como este poderia ser testado manualmente?
Sugiro avaliar os testes.
Algum cenário de contexto que queira dar?
NA.
Screenshots
NA.
Quais são tickets relevantes?
TK #685
Referências
NA.