Corrige atribuição de valores para is_public de Journal, Issue e Article e journal.current_status #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublic para journal, issue e article, e current_status para journal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Corrige atribuição de valores para is_public de Journal, Issue e Article e journal.current_status.
Corrige JournalFactory e ArticleFactory para atribuir valor para is_public para journal, issue e article, e current_status para journal.
O valor de current_status era computado ao receber os dados, no entanto, estava incorreto quando o periódico ainda está sendo trabalhado, é um periódico recém ingressado na coleção.
A atribuição de is_public foi alterada ao considerar que, às vezes, o objetivo é despublicar o journal, issue, ou artigo.
Onde a revisão poderia começar?
por commits
Como este poderia ser testado manualmente?
Executando
/api/v1/journale/api/vi1/articleAlgum cenário de contexto que queira dar?
n/a
Screenshots
n/a
Quais são tickets relevantes?
n/a
Referências
n/a