Usergroup #19
Open
Usergroup #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename users group -> usergroup in accordance with Guacamole - Added class GuacamoleUserGroupModule - Refactor existing code into methods - Add create_or_update_usergroup() - Add guacamole_get_usergroup() - Reflect RESTful resources in URL names - Added system permissions support - Added group member support - Removed WiP connections code - Added check_mode support - Added diff mode support - Minor fixes in documentation
|
thanks for your contribution @pberndt ! I a quick look it looks good so I will merge it upstream and I will publish version Can you add some basics tests using your module in devel-utils/test-collection.yml ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
based on the foundations of @pescobar I wrote a guacamole_usergroup module that allows to create Guacamole User Groups and add as well as remove users and system permissions.
It is still far from complete (because the Guacamole group/permissions hierarchy is quite extensive) but works already well enough for me and so I wanted to share it in the hope that it may be useful to someone else. I don't know when/if I will be able to work on this in the future, so I rather share it now than never, also, because I doubt that I will ever need the other features.
Best regards,
Philipp