breaking: Control Tower 3.0 support #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g group 'aws-controltower/CloudTrailLogs' into the management account the log metric and alarms in the audit and logging account are removed Signed-off-by: Stefan Wessels Beljaars <[email protected]>
Terraform Format and Style 🖌
|
stefanwb
force-pushed
the
control-tower-3-support
branch
2 times, most recently
from
ee887c5
to
6b1d87e
Compare
…publishing from the core-mangement account and adds policy to prevent error "loading the SNS subscriptions for topics" when viewing corresponding active CloudWatch alarms Signed-off-by: Stefan Wessels Beljaars <[email protected]>
stefanwb
force-pushed
the
control-tower-3-support
branch
from
be37371
to
b269707
Compare
…de consistent Signed-off-by: Stefan Wessels Beljaars <[email protected]>
stefanwb
force-pushed
the
control-tower-3-support
branch
from
0d1c0c9
to
ba32452
Compare
marwinbaumannsbp
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control Tower 3.0 support, with the consolidating of the log group 'aws-controltower/CloudTrailLogs' into the management account the log metric and alarms in the audit and logging account are removed
Also this PR changes the IAM Activity SNS topic policy to fix an error and scope it down in terms of publishing rights.
This fixes #178
Edit: Updated account baseline related to this change. See schubergphilis/terraform-aws-mcaf-account-baseline#15.