Set default value to null

schubergphilis · Nov 9, 2023 · ba91d09 · ba91d09
1 parent f0a4d50
commit ba91d09
Show file tree

Hide file tree

Showing 4 changed files with 117 additions and 13 deletions.
diff --git a/cloudtrail.tf b/cloudtrail.tf
@@ -12,19 +12,24 @@ resource "aws_cloudtrail" "additional_auditing_trail" {
   kms_key_id                 = var.additional_auditing_trail.kms_key_id
   tags                       = var.tags
 
-  event_selector {
-    dynamic "data_resource" {
-      for_each = var.additional_auditing_trail.event_selector.data_resource != null ? { create = true } : {}
+  dynamic "event_selector" {
+    for_each = var.additional_auditing_trail.event_selector != null ? { create = true } : {}
 
-      content {
-        type   = var.additional_auditing_trail.event_selector.data_resource.type
-        values = var.additional_auditing_trail.event_selector.data_resource.values
+    content {
+
+      dynamic "data_resource" {
+        for_each = var.additional_auditing_trail.event_selector.data_resource != null ? { create = true } : {}
+
+        content {
+          type   = var.additional_auditing_trail.event_selector.data_resource.type
+          values = var.additional_auditing_trail.event_selector.data_resource.values
+        }
       }
 
-    }
+      include_management_events        = var.additional_auditing_trail.event_selector.include_management_events
+      exclude_management_event_sources = var.additional_auditing_trail.event_selector.exclude_management_event_sources
+      read_write_type                  = var.additional_auditing_trail.event_selector.read_write_type
 
-    include_management_events        = var.additional_auditing_trail.event_selector.include_management_events
-    exclude_management_event_sources = var.additional_auditing_trail.event_selector.exclude_management_event_sources
-    read_write_type                  = var.additional_auditing_trail.event_selector.read_write_type
+    }
   }
 }
diff --git a/examples/basic/.terraform.lock.hcl b/examples/basic/.terraform.lock.hcl
diff --git a/examples/basic/main.tf b/examples/basic/main.tf
@@ -32,9 +32,7 @@ provider "datadog" {
 }
 
 provider "mcaf" {
-  aws {
-    region = "eu-west-1"
-  }
+  aws {}
 }
 
 module "landing_zone" {

diff --git a/variables.tf b/variables.tf
@@ -3,6 +3,7 @@ variable "additional_auditing_trail" {
     name       = string
     bucket     = string
     kms_key_id = string
+
     event_selector = optional(object({
       data_resource = optional(object({
         type   = string
@@ -13,6 +14,7 @@ variable "additional_auditing_trail" {
       read_write_type                  = optional(string, "All")
     }))
   })
+  default     = null
   description = "CloudTrail configuration for additional auditing trail"
 }