Merge pull request #212 from schubergphilis/fix_diagnotics

fix: Remove unused SES forwarder alias
schubergphilis · Oct 11, 2024 · 0aaea09 · 0aaea09
2 parents e033a01 + 2bde0cc
commit 0aaea09
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,6 +5,9 @@
 *.tfstate
 *.tfstate.*
 
+# Lock files
+.terraform.lock.hcl
+
 # Crash log files
 crash.log
 

diff --git a/ses_accounts_mail_alias.tf b/ses_accounts_mail_alias.tf
@@ -1,5 +1,6 @@
 module "ses-root-accounts-mail-alias" {
-  #checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth
+  # checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth
+
   count     = var.ses_root_accounts_mail_forward != null ? 1 : 0
   providers = { aws = aws, aws.route53 = aws }
 
@@ -13,11 +14,11 @@ module "ses-root-accounts-mail-alias" {
 }
 
 module "ses-root-accounts-mail-forward" {
-  #checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
-  #checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
-  #checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment
-  count     = var.ses_root_accounts_mail_forward != null ? 1 : 0
-  providers = { aws = aws, aws.lambda = aws }
+  # checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
+  # checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
+  # checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment
+
+  count = var.ses_root_accounts_mail_forward != null ? 1 : 0
 
   source  = "schubergphilis/mcaf-ses-forwarder/aws"
   version = "~> 0.3.0"