fix: duplicate rendering of extra empty lines #168
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @schollz
As I commented in Issue #97, the implementation that clears the current line fills too much extra space for the width of the terminal, and some terminal software makes it look as if the line is broken.
The reason is that in the current implementation
s.maxLineWidth
keeps increasing and exceeds the width of the terminal.progressbar/progressbar.go
Line 990 in 3d12297
I think that filling the space with the width of the terminal would probably solve the problem you are having, but could you please confirm this?
screenshots📸
before
If go run examples/basic on the master branch, it will look like this.
after
This PR solves this problem.