Replace kernel.root_dir with kernel.project_dir #522
Conversation
| @@ -78,7 +86,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $files = $this->retrieveFiles($dirs); | |||
|
|
|||
| foreach ($files as $file) { | |||
| $path = str_replace($basePath, '%kernel.root_dir%', $file); | |||
| $path = str_replace($basePath, '%kernel.project_dir%', $file); | |||
There was a problem hiding this comment.
I guess this wasn't working before because it was replacing $basePath which contained '%kernel.root_dir%/..' with '%kernel.root_dir%'
franmomu
force-pushed
the
use_project_dir
branch
5 times, most recently
from
0f594cd to
345d45f
Compare
|
can you please rebase this? |
franmomu
force-pushed
the
use_project_dir
branch
from
345d45f to
88efd77
Compare
|
thanks! |
|
@goetas can you please tag a new release with this? |
|
Will prepare it in the next days. @franmomu is there something that you have still planned to do? What do you think about? |
I don't have anything more planned to do, I think it's ready to tag a new release. |
|
Ok, then I have it on my todo list. (I hope so),... The last feature release was years ago |
Description
kernel.root_dirwas deprecated in Symfony 4.2 and is removed in 5.0. This PR tries to replacekernel.root_dirbykernel.project_dirwherever is possible and do not usekernel.root_dirif is not defined. I also changed the docs to reference thetranslationsfolder at the root directory of the project (which is the recommended place).After this one (and #523), I think the only left to do to be able to use SF5 are commands, I'll take a look then.