Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address namespace change in Twig #519

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Address namespace change in Twig #519

merged 1 commit into from
Feb 21, 2020

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Feb 5, 2020

Q A
Bug fix? yes, if you consider deprecation notices as bugs
New feature? no
BC breaks? no
Deprecations? no
Tests pass? not less than before
Fixed tickets
License Apache2

Description

Twig has switched to PSR-4 namespaces, and PSR-0 is dropped in Twig 3.

Refs #516

@goetas
Copy link
Collaborator

goetas commented Feb 6, 2020

@greg0ire can you please fix the conflict?

@greg0ire
Copy link
Contributor Author

Ping @goetas

@greg0ire greg0ire mentioned this pull request Feb 20, 2020
Closed
@goetas goetas merged commit 7b927b8 into schmittjoh:master Feb 21, 2020
@goetas
Copy link
Collaborator

goetas commented Feb 21, 2020

thanks

@greg0ire greg0ire deleted the twig-3 branch February 21, 2020 06:51
@goetas goetas mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @goetas