Compile nodes before comparing them #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure since when, but parsing is not enough to obtain the same code from different fixtures. Adding that extra step fixes the failing tests and the build.
|
At least one of the jobs is failing 🤦♂️ … and the error message is not helpful at all, not sure what to do. EDIT: oh wait, it actually contains something helpful: |
|
Note that many of the jobs are green though, so maybe this can be merged as is? I mean it's an improvement for sure… |
|
Thanks @greg0ire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not sure since when, but parsing is not enough to obtain the same code
from different fixtures.
Adding that extra step fixes the failing tests and the build.