Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated usage of TreeBuilder on Symfony 4 #513

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Remove deprecated usage of TreeBuilder on Symfony 4 #513

merged 2 commits into from
Oct 7, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Oct 4, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Supports usage of TreeBuilder in Symfony 4.2+.

Todos

  • Tests
  • Documentation
  • Changelog

@goetas
Copy link
Collaborator

goetas commented Oct 7, 2019

Hi, all the tests are failing with Undefined property: JMS\TranslationBundle\DependencyInjection\Configuration::$rootNodeName

@emodric
Copy link
Contributor Author

emodric commented Oct 7, 2019

Whoops, sorry about that! Fixed now!

@goetas
Copy link
Collaborator

goetas commented Oct 7, 2019

looks good. test failures are not related to this.

@goetas goetas merged commit 6bc3513 into schmittjoh:master Oct 7, 2019
@goetas
Copy link
Collaborator

goetas commented Oct 7, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emodric @goetas