Prevent NPE when service lacks identity (hashicorp#19987)

Fixes a null pointer exception if `Alloc.SignIdentities` was called for any service and any service lacked an identity. Fixes hashicorp#19986
schmichael · Feb 22, 2024 · 14280e0 · 14280e0
1 parent cce72cd
commit 14280e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changelog/19986.txt b/.changelog/19986.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+server: Prevent NPE when service lacks identity
+```
diff --git a/nomad/structs/workload_id.go b/nomad/structs/workload_id.go
@@ -312,7 +312,10 @@ type WIHandle struct {
 	WorkloadType       WorkloadType
 }
 
-func (w WIHandle) Equal(o WIHandle) bool {
+func (w *WIHandle) Equal(o WIHandle) bool {
+	if w == nil {
+		return false
+	}
 	return w.IdentityName == o.IdentityName &&
 		w.WorkloadIdentifier == o.WorkloadIdentifier &&
 		w.WorkloadType == o.WorkloadType