Fix canceling file selector on Windows Edge sometimes blocks UI #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! I cannot reproduce the issue. Which OS and browser do you use? Could you maybe provide a screencast? Also, please rebase your branch, so the changes to github-image.yml are not included in this PR. |
schlagmichdoch
changed the title
schlagmichdoch
added
bug
|
this changes has some code not relate to this problem, i'll recommit a new pull request |
|
on Win10 and Microsoft Edge with 121.0.2277.83 |
|
Wow that’s weird behavior by Edge, thanks for the screencast! You don’t need to open another PR. I’ll commit it to another branch and add you as co-author. Thanks for your contribution! |
5 tasks
schlagmichdoch
changed the title
schlagmichdoch
changed the title
schlagmichdoch
added a commit
that referenced
this pull request
Feb 7, 2024
schlagmichdoch
added a commit
that referenced
this pull request
Feb 9, 2024
schlagmichdoch
added a commit
that referenced
this pull request
Feb 9, 2024
schlagmichdoch
added a commit
that referenced
this pull request
Feb 9, 2024
## Enhancements - Implemented drag and drop into text fields - Tidy up code - Translations update from Hosted Weblate (Italian) ## Fixes - Received URLs with single letter subdomains not hydrated into links #258 - Button does not change color on hover (#262 + #263) - On Windows Edge, PeerUI shows „preparing“ when file selector is cancelled (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to reproduce this problem:
select file -> upload
select file again -> canel file select
then the ui blocked