Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle LEN function for Redshift #212

Merged
merged 3 commits into from
Jun 10, 2024
Merged

feat: handle LEN function for Redshift #212

merged 3 commits into from
Jun 10, 2024

Conversation

Smlep
Copy link
Contributor

@Smlep Smlep commented Jun 8, 2024 •
edited
Loading

Allow using LEN function when mocking redshift queries

See #213

@Smlep Smlep mentioned this pull request Jun 8, 2024
Open
4 tasks
@DanCardin DanCardin force-pushed the feature/add-redshift-len branch from f21f214 to 4938638 Compare June 10, 2024 13:57
@DanCardin
Copy link
Contributor

Added a basic test, but otherwise looks good!

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9449705181

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.464%
Totals Coverage Status
Change from base Build 8688983856: 0.005%
Covered Lines: 1440
Relevant Lines: 1590
💛 - Coveralls

@DanCardin DanCardin merged commit 67886e0 into schireson:main Jun 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanCardin DanCardin DanCardin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smlep @DanCardin @coveralls @sam-courtemanche-wmx