Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: also allow psycopg2-binary as a valid driver #208

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: also allow psycopg2-binary as a valid driver #208

merged 1 commit into from
Apr 15, 2024

Conversation

willmclaren
Copy link
Contributor

v2.10.2 introduced a change that broke our CI since we use psycopg2-binary instead of psycopg2.

This change allows either as a valid driver.

@DanCardin
Copy link
Contributor

Ah yes, good call good call. Thanks for the fix!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8688771059

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.459%
Totals Coverage Status
Change from base Build 8650835071: 0.0%
Covered Lines: 1439
Relevant Lines: 1589
💛 - Coveralls

@DanCardin DanCardin merged commit d3f87de into schireson:main Apr 15, 2024
20 checks passed
@willmclaren willmclaren deleted the wm/fix-driver-discover-for-psycopg2-binary branch April 15, 2024 12:34
@DanCardin DanCardin mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanCardin DanCardin DanCardin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmclaren @DanCardin @coveralls