Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the region when creating the client to assume roles. #194

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

DanCardin
Copy link
Contributor

@DanCardin DanCardin commented Jul 24, 2023

Fixes an issue where certain uses' lack of aws env vars being set lead to a missing region error. I had thought this was fixed in the prior PR, not sure how this got passed it before, because it should be being hit in every invocation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5648772599

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.694%

Totals Coverage Status
Change from base Build 5535946610: 0.0%
Covered Lines: 1385
Relevant Lines: 1516

💛 - Coveralls

@DanCardin DanCardin marked this pull request as ready for review July 24, 2023 19:11
@DanCardin DanCardin merged commit 2236bbe into main Jul 24, 2023
@DanCardin DanCardin deleted the dc/set-region-during-role-assumption branch July 24, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants