Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add an option to configure the default test registration path. #73

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: Add an option to configure the default test registration path. #73

merged 1 commit into from
Feb 21, 2023

Conversation

DanCardin
Copy link
Contributor

@DanCardin DanCardin commented Feb 21, 2023 •
edited
Loading

Fixes #69

@DanCardin DanCardin force-pushed the dc/tests-path branch 3 times, most recently from e9b7744 to 160f400 Compare February 21, 2023 20:11
@DanCardin DanCardin changed the title fix: Test migration down to base correctly arrives at "base" revision. fix: Add an option to configure the default test registration path. Feb 21, 2023
oakhan3
oakhan3 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@oakhan3 oakhan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be possible better API if --test-alembic took in an optional path imo, but this works just as well

@DanCardin
Copy link
Contributor Author

I dont necessarily disagree, i just dont think i can backwards compatibly apply that, and/or whether pytest's option system lets you do that.

@DanCardin DanCardin merged commit c4920c9 into main Feb 21, 2023
@DanCardin DanCardin deleted the dc/tests-path branch February 21, 2023 20:37
@jarviliam jarviliam mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakhan3 oakhan3 oakhan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pytest-alembic doesn't understand the type of a mocked resource
2 participants
@DanCardin @oakhan3