This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
Add support to specify s3 filenames for screenshots #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for setting filenames from test code explicitly and dynamically, rather than statically via env variables. .
|
Hi Team, Did you have feedback on this change? I was hoping to get this landed into the master branch so I can reference this instead of my own fork in my personal projects. Thanks! |
|
Hi There, Just resolved a minor formatting conflict. This commit is ready to go. Would an admin with write access please accept this change? Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for setting filenames from test code explicitly and dynamically, rather than statically via env variables.
.