Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TwoFactorProviderDecider #215

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

danielburger1337
Copy link
Contributor

See #212

Every scenario should have a dedicated test case.
I would appreciate it if we could merge and release this feature ASAP.

@scheb
Copy link
Owner

scheb commented Jan 9, 2024

Thanks for handing this in. On the first view, this is looking quite good. I'll look into this more in detail, once I find time to.

Copy link
Owner

@scheb scheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR! 👍

I have not much to change on that. I'd change the interface of the decider slightly, other than that, the approach looks really good.

doc/configuration.rst Outdated Show resolved Hide resolved
@scheb scheb merged commit 1b74ad2 into scheb:7.x Jan 18, 2024
7 checks passed
@scheb
Copy link
Owner

scheb commented Jan 18, 2024

Excellent PR, thank you! Merged and released as v7.1.0

@danielburger1337 danielburger1337 deleted the provider-decider branch January 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants