Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared workflow to update pre-commit hooks. #24

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Conversation

devanubis
Copy link
Contributor

@devanubis devanubis commented Oct 27, 2023

To be used by:

All steps pass except creating the PR, which can't happen from a PR so until we merge 322 and trigger the workflow against main it won't work.

@dolfandringa dolfandringa requested a review from a team October 30, 2023 05:36
Copy link
Contributor

@dolfandringa dolfandringa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to add pre-commit autoupdate? What does it do for us? Also, could you add CODEREVIEWERS correctly? Now this repo doesn't ask zuos-reviewers for a review automatically.

@devanubis
Copy link
Contributor Author

It updates the hook versions. So they don't lag (too far) behind the main dependencies managed by dependabot.

Dependabot don't support updating .pre-commit-conf.yaml so this is the next best option.

@devanubis
Copy link
Contributor Author

Codeowners as a separate PR  just to have a separate history: #25

@dolfandringa dolfandringa self-requested a review October 31, 2023 05:26
@devanubis devanubis merged commit bced8b3 into main Oct 31, 2023
@devanubis devanubis deleted the pre-commit-autoupdate branch October 31, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants