fix: 125 control net options should have the same naming as on the webapp #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame-naming-as-on-the-webapp
…ame-naming-as-on-the-webapp
According to tag some modalities option are now available. And has a corresponding translation to call correct modality inside api.
|
Opening prompt window without modifying the model does not prefill Modalities value: |
|
@TheLLspectre still waiting for your fixes on this |
|
How to reproduce this ?? I don't have this behaviour :/ @qvaleroo
|
|
I do not reproduce, after starting from scratch. Let's merge. I let you handle conflicts |
The only way I had to reproduce it, it's on a first install and launch, when I don't have any model selected and here I don't had modalities but it's normal
|
…ame-naming-as-on-the-webapp
|
I managed conflict with a merge dev into branch ! |
qvaleroo
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now according to modalities available on the webapp and SDXL / SD 1.5 tags, we have same options available on Unity plugin.
Adding an array of translation of those modalities to manage api request and displaying interface in Unity.
Also renaming some variables.