feat: Global leaderboard #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarvalhojr
reviewed
Nov 22, 2023
aoc-client/src/lib.rs
Outdated
| debug!("🦌 Fetching global leaderboard for {}", self.year); | ||
|
|
||
| let url = format!("https://adventofcode.com/{}/leaderboard", self.year); | ||
| let response = reqwest::blocking::get(url)?; |
There was a problem hiding this comment.
Any reason to use reqwest directly instead of calling http_client? This way you're missing some common error handling there and also not passing the user agent header.
There was a problem hiding this comment.
I just used reqwest directly because I saw the session cookie wasn't required for grabbing the global leaderboard. Happy to switch it over for the error handling :)
scarvalhojr
reviewed
Nov 22, 2023
|
|
||
| let url = format!("https://adventofcode.com/{}/leaderboard", self.year); | ||
| let response = reqwest::blocking::get(url)?; | ||
| let contents = response.error_for_status()?.text()?; |
There was a problem hiding this comment.
It might be a good idea to handle NOT FOUND which can only happen if the year is invalid (like it's done in get_calendar_html):
if response.status() == StatusCode::NOT_FOUND {
// A 404 reponse means the leaderboard for
// the requested year is not yet available
return Err(AocError::InvalidEventYear(self.year));
}
There was a problem hiding this comment.
Makes sense! Added :)
|
Thanks for this! I haven't finished reviewing it but I dropped some initial comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in
CONTRIBUTING.md, this feature adds the ability to display the Global Leaderboard for a given year.I've tested this on all years and it appears to be functioning correctly, but I'm happy to refactor/ fix things if they're not up to standard :)
Screenshot of (the start of) 2022:
