feat: Add event stats #16
Conversation
fix: Proper display of stars for 2022 Day 25
| .get(url) | ||
| .send()?; | ||
| let contents = response.error_for_status()?.text()?; | ||
|
|
There was a problem hiding this comment.
We need to handle 404 here as well, which can happen if you request stats from future events (say, 2024).
| let star_val = stats_text | ||
| .split_whitespace() | ||
| .find(|chunk| chunk.parse::<u64>().is_ok()) | ||
| .unwrap() |
There was a problem hiding this comment.
This unwrap is a bit dangerous. We need to handle it in case the page format changes in the future (we could return a AocResponseError to flag this). For instance, this currently panics if you ask for the 2023 stats, which gets an almost blank page with a "no stats yet" message. We could use a regex to make sure we get the right number looking for something like represents up to <number> users
There was a problem hiding this comment.
That makes sense. I initially avoided using a regex because I don't have any experience using them (yet), but I'll look into this. Thanks!
aoc-client/src/lib.rs
Outdated
| let split: Vec<&str> = line.split_whitespace().collect(); | ||
| let gold_comps = split[1].parse::<usize>().unwrap(); | ||
| let n_stars = split[3].len(); |
There was a problem hiding this comment.
This also assumes the page format won't change. Maybe a regex would be safer (and return error if it doesn't match).
There was a problem hiding this comment.
Likewise here, I will start working on switching this functionality over to a regex. Thanks so much for the feedback!
As suggested in
CONTRIBUTING.md, this feature adds the ability to display the Event Stats for a given year.I've tested this on all years and it appears to be functioning correctly, but I'm happy to refactor/ fix things if they're not up to standard :)
Screenshot of 2022:
