Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Scala 2.12.20 and 3.5.0 #869

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Johnnei
Copy link
Contributor

@Johnnei Johnnei commented Sep 12, 2024

Closes #866, #867 and #862

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (fa90063) to head (62e4f84).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   88.08%   82.45%   -5.64%     
==========================================
  Files         142       19     -123     
  Lines        1578      302    -1276     
  Branches      278       32     -246     
==========================================
- Hits         1390      249    -1141     
+ Misses        188       53     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@saeltz saeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!

Would you please also change the Scala versions in .github/workflows/pr-checks.yml?

@Johnnei
Copy link
Contributor Author

Johnnei commented Sep 13, 2024

Thanks for creating this PR!

Would you please also change the Scala versions in .github/workflows/pr-checks.yml?

Oh my bad, forgot about CI versions.

Copy link
Collaborator

@saeltz saeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks a ton!

@mccartney, would you issue a new release please?

@saeltz saeltz merged commit 559aa96 into scapegoat-scala:master Sep 13, 2024
14 of 15 checks passed
@Johnnei Johnnei deleted the support-21220 branch September 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants