Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from setup-scala to setup-java action #833

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Conversation

saeltz
Copy link
Collaborator

@saeltz saeltz commented Apr 1, 2024

Setup-scala is not maintained anymore and uses Node.js 16. Node.js 16 actions are deprecated. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@saeltz saeltz marked this pull request as ready for review April 1, 2024 12:29
@saeltz saeltz requested a review from mccartney April 13, 2024 20:56
Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
Confirmed with https://github.com/olafurpg/setup-scala/releases/tag/v14.

setup-java seems to be an official Github action (?), so I think we are fine with just using the major version v4 and not pinning the exact version.

@saeltz saeltz merged commit 8a398b1 into master Apr 13, 2024
9 checks passed
@saeltz saeltz deleted the saeltz-patch-1 branch April 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants