Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Angle brackets no longer cause malformed html reports #815

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Johnnei
Copy link
Contributor

@Johnnei Johnnei commented Feb 22, 2024

PointlessTypeBound inspection has angle brackets in the explanation. The HTML report tries to pretty format the code and parse it back to XML element which has dangling angle brackets causing failure.

Fixes scapegoat-scala/sbt-scapegoat#175

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9ce6a8c) 86.75% compared to head (9fc1bdf) 88.08%.

Files Patch % Lines
...a/com/sksamuel/scapegoat/io/HtmlReportWriter.scala 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   86.75%   88.08%   +1.33%     
==========================================
  Files         142      142              
  Lines        1578     1578              
  Branches      274      278       +4     
==========================================
+ Hits         1369     1390      +21     
+ Misses        209      188      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@saeltz saeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saeltz saeltz merged commit 30fef3c into scapegoat-scala:master Feb 22, 2024
9 checks passed
@saeltz
Copy link
Collaborator

saeltz commented Feb 22, 2024

@mccartney, would you release a new patch version please?

@Johnnei Johnnei deleted the fix-html-report branch February 22, 2024 17:41
@mccartney
Copy link
Collaborator

2.1.4 is on its way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when compiling
4 participants