Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slf4j-api to 2.0.9 #788

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates org.slf4j:slf4j-api from 2.0.7 to 2.0.9

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-api" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.slf4j", artifactId = "slf4j-api" }
}]
labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (756847b) 87.22% compared to head (e454eb2) 87.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files         141      141           
  Lines        1527     1527           
  Branches      254      254           
=======================================
  Hits         1332     1332           
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Johnnei
Copy link
Contributor

Johnnei commented Sep 11, 2023

Note: slf4j is only breaking for the logger impl binding part. Probably need to wait until the default loggers in sbt/gradle/maven are updated to slf4j 2.x before merging this.

@saeltz
Copy link
Collaborator

saeltz commented Sep 11, 2023

@Johnnei, what's breaking here? The tests are green.

@Johnnei
Copy link
Contributor

Johnnei commented Sep 11, 2023

@Johnnei, what's breaking here? The tests are green.

They've changed the flow for Logback / log4j / etc, to register themselves. Usually results in a nice warning on startup and slf4j telling it defaults to the no-op impl.

Client-side code has not been impacted by 2.x so CI will be green for sure (unless we test very specifically for logging)

Looking at some of the CI checks it doesn't seem like the logging is gone though, so either sbt is already up to date or it doesn't impact sbt the way I expected to 🤔

https://www.slf4j.org/faq.html#changesInVersion200

@Johnnei
Copy link
Contributor

Johnnei commented Sep 11, 2023

quick google: sbt/sbt#7062 think sbt already upgraded.

@saeltz
Copy link
Collaborator

saeltz commented Sep 11, 2023

This just updates 2.0.7 to 2.0.9. Isn't the change in slf4j already in effect since 2.0.0?
I don't see anything suspicious in the recent changes (qos-ch/slf4j@v_2.0.7...v_2.0.9).

@Johnnei
Copy link
Contributor

Johnnei commented Sep 11, 2023

Do'h! Missed that part completely 🤦 My bad.

@saeltz saeltz merged commit c9ac947 into scapegoat-scala:master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants