Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate code in html report #779

Merged

Conversation

eugene-sy
Copy link
Contributor

fixes #402

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (0325ec1) 87.28% compared to head (fc8b72f) 87.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   87.28%   87.22%   -0.06%     
==========================================
  Files         141      141              
  Lines        1526     1527       +1     
  Branches      252      254       +2     
==========================================
  Hits         1332     1332              
- Misses        194      195       +1     
Files Changed Coverage Δ
...a/com/sksamuel/scapegoat/io/HtmlReportWriter.scala 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@mccartney mccartney self-requested a review September 8, 2023 08:42
@mccartney
Copy link
Collaborator

The check failure doesn't seem related. I guess we have some kind of infra regression.

@Johnnei
Copy link
Contributor

Johnnei commented Sep 8, 2023

The check failure doesn't seem related. I guess we have some kind of infra regression.

[error]  import scala.xml.{Elem, Unparsed, XML}
[error] +
[error]  import com.sksamuel.scapegoat.{Feedback, Levels}

I think it is complaining about a missing empty line?

@eugene-sy
Copy link
Contributor Author

@Johnnei thanks for pointing that out!

@eugene-sy eugene-sy merged commit 756847b into scapegoat-scala:master Sep 9, 2023
@eugene-sy eugene-sy deleted the remove-backticks-in-httml branch September 9, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip backticks from console output and HTML reports
4 participants