Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Scala 2.12.18 #744

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Support Scala 2.12.18 #744

merged 1 commit into from
Jun 2, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jun 1, 2023

  • Drop support for Scala 2.12.16

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cfd16ef) 87.28% compared to head (ad66fbf) 87.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         141      141           
  Lines        1526     1526           
  Branches      254      254           
=======================================
  Hits         1332     1332           
  Misses        194      194

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

saeltz
saeltz approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@saeltz saeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@mccartney, should we release a new minor version?

@saeltz saeltz merged commit 5dfde14 into scapegoat-scala:master Jun 2, 2023
@lolgab lolgab deleted the update-scala-2.12 branch June 3, 2023 11:15
@lolgab
Copy link
Contributor Author

lolgab commented Jun 3, 2023 •
edited
Loading

I'm opening a new PR for Scala 2.13.11. You can release a new patch version after that (or minor if you also have other changes that require a minor version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeltz saeltz saeltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @codecov-commenter @saeltz