Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ExistsSimplifiableToContains #711

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

saeltz
Copy link
Collaborator

@saeltz saeltz commented Nov 28, 2022

Fixes #122. Added the test just to confirm we don't have a false positive. I think it's worth keeping for the future.

@saeltz saeltz marked this pull request as ready for review November 28, 2022 19:18
@saeltz saeltz requested a review from mccartney November 28, 2022 19:18
compiler.scapegoat.feedback.warnings.size shouldBe 0
}

"when a Map's key and value are of the same time" in {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/time/type/?

@saeltz saeltz merged commit a3036e2 into scapegoat-scala:master Nov 28, 2022
@saeltz saeltz deleted the 122 branch November 28, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive: ExistsSimplifableToContains
2 participants