Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecations in FeedbackTest #709

Merged
merged 5 commits into from
Nov 26, 2022

Conversation

saeltz
Copy link
Collaborator

@saeltz saeltz commented Nov 26, 2022

These deprecations came into effect with Scala 2.12. Since we dropped support for Scala 2.11, I did the changes.

Also removing some specific scalac options for not any longer supported patch versions of Scala 2.13.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Base: 87.82% // Head: 87.11% // Decreases project coverage by -0.70% ⚠️

Coverage data is based on head (edb0c10) compared to base (98cfc7e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   87.82%   87.11%   -0.71%     
==========================================
  Files         141      141              
  Lines        1519     1521       +2     
  Branches      241      221      -20     
==========================================
- Hits         1334     1325       -9     
- Misses        185      196      +11     
Impacted Files Coverage Δ
...pections/collections/PredefIterableIsMutable.scala 14.28% <100.00%> (-85.72%) ⬇️
...tions/collections/PredefTraversableIsMutable.scala 14.28% <100.00%> (-69.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saeltz saeltz marked this pull request as ready for review November 26, 2022 19:40
@saeltz saeltz merged commit 7407ec6 into scapegoat-scala:master Nov 26, 2022
@saeltz saeltz deleted the deprecations branch November 26, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants